libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ensure $MV is set before each use [libtool--gary--1.0--patch-30]


From: Ralf Wildenhues
Subject: Re: ensure $MV is set before each use [libtool--gary--1.0--patch-30]
Date: Tue, 10 May 2005 10:53:15 +0200
User-agent: Mutt/1.4.1i

Hi Gary,

* Gary V. Vaughan wrote on Sat, May 07, 2005 at 04:30:46PM CEST:
> 
> Okay to commit to HEAD and branch-2-0?
> 
>       Some macros had relied on accidentally correct ordering in order
>       for $MV to be defined before use.  Factor out setting of some
>       common file commands and m4_require it before use:
> 
>       * libltdl/m4/libtool.m4 (_LT_PROG_DEFAULTS): Allow user to

There is not file libltdl/m4/libtool.m4 (but I may be dealing with your
patches in the wrong order? :-)

>       override some common file commands at configure time.
>       (_LT_SETUP, _LT_CONFIG, _LT_COMPILER_OPTION, _LT_LINKER_OPTION)
>       (_LT_COMPILER_C_O, _LT_COMPILER_FILE_LOCKS)
>       (_LT_SYS_DYNAMIC_LINKER, _LT_LINKER_SHLIBS, _LT_LANG_CXX_CONFIG)
>       (_LT_SYS_HIDDEN_DEPLIBS): m4_require it to ensure the commands are
>       defined before they are called.

I don't see where MV or CP are used at `configure' time, only RM, but
that's ok.  Also, I believe I want to be able to choose a different RM
at configure time than at compile time, for debugging reasons.  This too
is possible with your patch.

That brabbling done, I like your patch, please apply.  The only change I
request you to think about is maybe a different name -- how about
_LT_FILEUTILS_DEFAULTS?

Thinking out loud, it might be a good idea to merge my proposed
_LT_CHECK_POSIX_SORT (and similar tests which might prove necessary for
some of the other tools) to a _LT_FILEUTILS_POSIX which tests all of
them.

BTW, we eventually need to talk about m4 execution time, too.
bootstrapping HEAD is much slower than branch-2-0, which in turn is much
slower than branch-1-5.  Does m4 scale exponentially in the maximal
encountered macro depth?  How can I find this out, and could something
be done about it?  Note I have shyed away from m4 as much as I could
until now, so a documentation hint should suffice for a start.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]