Re: branch-1-5 case statement consistency

[Ralf Wildenhues]

Hi Tim,

Are you subscribed, BTW?  I.e., can we omit the spam-nontrapping
address?

* Tim Rice wrote on Thu, Sep 22, 2005 at 05:21:23AM CEST:
> 
> CVS branch-1-5
> pulled Sun Sep 18 13:22:46 PDT 2005
> 
> Here is a patch to branch-1-5 that adds the missing ;; lines
> to some case statements.

Thank you very much!  I have applied it together with a misindentation
to branch-1-5 and forward-ported it to CVS HEAD, as shown below.

> While having them gone does not cause any failures that I know of,
> it's nice to be consistent.

Yes, it is.  Do you have some automated method to find these?

> It will apply with some fuzz. I pulled it out of a UnixWare patch I
> am working on.

You might want to try running the testsuite from HEAD -- it might expose
more issues than the branch-1-5 one.  In any case, we like patches
against CVS HEAD even more.  :)

Cheers,
Ralf

2005-09-22  Tim Rice  <address@hidden>

        * libltdl/m4/libtool.m4 (LT_PATH_NM, _LT_LINKER_SHLIBS)
        (_LT_LANG_CXX_CONFIG, _LT_SYS_HIDDEN_LIBDEPS):
        Add missing `;;' after case list.

Index: libltdl/m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/m4/libtool.m4,v
retrieving revision 1.21
diff -u -r1.21 libtool.m4
--- libltdl/m4/libtool.m4       22 Sep 2005 04:53:14 -0000      1.21
+++ libltdl/m4/libtool.m4       22 Sep 2005 06:01:44 -0000
@@ -2902,6 +2902,7 @@
          continue # so that we can try to find one that supports BSD flags
          ;;
        esac
+        ;;
       esac
     fi
   done
@@ -4076,6 +4077,7 @@
            break
          fi
          done
+         ;;
        esac
 
        exp_sym_flag='-bexport'
@@ -4114,6 +4116,7 @@
          _LT_TAGVAR(hardcode_libdir_flag_spec, $1)='-L$libdir'
          _LT_TAGVAR(hardcode_libdir_separator, $1)=
          fi
+         ;;
        esac
        shared_flag='-shared'
        if test "$aix_use_runtimelinking" = yes; then
@@ -4126,11 +4129,11 @@
        # chokes on -Wl,-G. The following line is correct:
          shared_flag='-G'
        else
-       if test "$aix_use_runtimelinking" = yes; then
+         if test "$aix_use_runtimelinking" = yes; then
            shared_flag='${wl}-G'
          else
            shared_flag='${wl}-bM:SRE'
-       fi
+         fi
        fi
       fi
 
@@ -5069,6 +5072,7 @@
                ;;
              esac
            done
+           ;;
           esac
 
           exp_sym_flag='-bexport'
@@ -6036,6 +6040,7 @@
     _LT_TAGVAR(postdeps,$1)='-lCstd -lCrun'
     ;;
   esac
+  ;;
 esac
 ])