include_expsyms clobbers user files. (was: Libtool stresstest.at segfault on Cygwin/MinGW)

[Peter Ekberg]

* Ralf Wildenhues wrote on Wednesday, September 21, 2005 22:37 CEST:
> * Peter Ekberg wrote on Mon, Sep 19, 2005 at 09:05:04PM CEST:

*snip*

> > Thinking about it further, include_expsyms is perhaps not
> > buggy with skipped exports, as then the needed symbols perhaps
> > get exported anyway with the export_symbols_cmds functionality.
> > A check wouldn't hurt though...
> 
> ACK.

But looking closer, include_expsyms is a disaster area. Since it
isn't used, my vote is to zap it completely.

The problem is that it potentially clobbers user provided files,
so that building repeatedly will eat up all your disk space
eventually (but that isn't the worst problem with clobbering
user provided files of course).

The following piece of code:

        if test -n "$export_symbols" && test -n "$include_expsyms"; then
          tmp_export_symbols="$export_symbols"
          test -n "$orig_export_symbols" &&
tmp_export_symbols="$orig_export_symbols"
          $opt_dry_run || eval '$ECHO "X$include_expsyms" | $Xsed |
$SP2NL >> "$tmp_export_symbols"'
        fi

simply appends lines to $tmp_export_symbols which (in some
cases) is the file provided with the -export-symbols option.

So, zap it? Or is include_expsyms somehow a hook for "outside
users"?

Cheers,
Peter