Re: branch-1-5 UnixWare fixes

[Tim Rice]

On Mon, 26 Sep 2005, Ralf Wildenhues wrote:

: Hi Tim,
: 
: * Tim Rice wrote on Sun, Sep 25, 2005 at 10:05:21PM CEST:
: > On Sun, 25 Sep 2005, Ralf Wildenhues wrote:
: > : * Tim Rice wrote on Fri, Sep 23, 2005 at 10:20:29PM CEST:
[snip]
: > I re-ran the tests using ksh88 and all tests passed.
: > Must be a ksh bug.
: > Version M-11/16/88h         passes quote test
: > Version M-12/28/93e-SCO             fails quote test
: 
: Please post the failing output of
:   make check TESTS=quote.test VERBOSE=x
: 
: Thank you.

-----------< begin "make check TESTS=quote.test VERBOSE=x" >------------
address@hidden 14% gmake check TESTS=quote.test VERBOSE=x
Making check in .
gmake[1]: Entering directory `/usr/local/src/gnu/libtool-1.5/build'
gmake[1]: Nothing to be done for `check-am'.
gmake[1]: Leaving directory `/usr/local/src/gnu/libtool-1.5/build'
Making check in libltdl
gmake[1]: Entering directory `/usr/local/src/gnu/libtool-1.5/build/libltdl'
gmake[1]: Leaving directory `/usr/local/src/gnu/libtool-1.5/build/libltdl'
Making check in doc
gmake[1]: Entering directory `/usr/local/src/gnu/libtool-1.5/build/doc'
gmake[1]: Nothing to be done for `check'.
gmake[1]: Leaving directory `/usr/local/src/gnu/libtool-1.5/build/doc'
Making check in tests
gmake[1]: Entering directory `/usr/local/src/gnu/libtool-1.5/build/tests'
gmake  check-TESTS
gmake[2]: Entering directory `/usr/local/src/gnu/libtool-1.5/build/tests'
=== Running quote.test
== compile mode
= trying: no quoting
= passed: mkdir .libs
 cc -c -DVAR=test foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c -DVAR=test foo.c -o foo.o >/dev/null 2>&1
= trying: \\ quoting
= failed: mkdir .libs
 cc -c "-DVAR=\\test\\" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=\\test\\" foo.c -o foo.o >/dev/null 2>&1
= trying: \" quoting
= failed: mkdir .libs
 cc -c "-DVAR=\"test\"" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=\"test\"" foo.c -o foo.o >/dev/null 2>&1
= trying: \` quoting
= failed: mkdir .libs
 cc -c "-DVAR=\`test\`" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=\`test\`" foo.c -o foo.o >/dev/null 2>&1
= trying: \$ quoting
= failed: mkdir .libs
 cc -c "-DVAR=\$test\$" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=\$test\$" foo.c -o foo.o >/dev/null 2>&1
= trying: "[" quoting
= passed: mkdir .libs
 cc -c "-DVAR=[test[" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=[test[" foo.c -o foo.o >/dev/null 2>&1
= trying: "]" quoting
= passed: mkdir .libs
 cc -c "-DVAR=]test]" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=]test]" foo.c -o foo.o >/dev/null 2>&1
= trying: "~" quoting
= passed: mkdir .libs
 cc -c "-DVAR=~test~" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=~test~" foo.c -o foo.o >/dev/null 2>&1
= trying: "#" quoting
= passed: mkdir .libs
 cc -c "-DVAR=#test#" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=#test#" foo.c -o foo.o >/dev/null 2>&1
= trying: "^" quoting
= passed: mkdir .libs
 cc -c "-DVAR=^test^" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=^test^" foo.c -o foo.o >/dev/null 2>&1
= trying: "&" quoting
= passed: mkdir .libs
 cc -c "-DVAR=&test&" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=&test&" foo.c -o foo.o >/dev/null 2>&1
= trying: "*" quoting
= passed: mkdir .libs
 cc -c "-DVAR=*test*" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=*test*" foo.c -o foo.o >/dev/null 2>&1
= trying: "(" quoting
= passed: mkdir .libs
 cc -c "-DVAR=(test(" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=(test(" foo.c -o foo.o >/dev/null 2>&1
= trying: ")" quoting
= passed: mkdir .libs
 cc -c "-DVAR=)test)" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=)test)" foo.c -o foo.o >/dev/null 2>&1
= trying: "{" quoting
= passed: mkdir .libs
 cc -c "-DVAR={test{" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR={test{" foo.c -o foo.o >/dev/null 2>&1
= trying: "}" quoting
= passed: mkdir .libs
 cc -c "-DVAR=}test}" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=}test}" foo.c -o foo.o >/dev/null 2>&1
= trying: "|" quoting
= passed: mkdir .libs
 cc -c "-DVAR=|test|" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=|test|" foo.c -o foo.o >/dev/null 2>&1
= trying: ";" quoting
= passed: mkdir .libs
 cc -c "-DVAR=;test;" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=;test;" foo.c -o foo.o >/dev/null 2>&1
= trying: "<" quoting
= passed: mkdir .libs
 cc -c "-DVAR=<test<" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=<test<" foo.c -o foo.o >/dev/null 2>&1
= trying: ">" quoting
= passed: mkdir .libs
 cc -c "-DVAR=>test>" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=>test>" foo.c -o foo.o >/dev/null 2>&1
= trying: "?" quoting
= passed: mkdir .libs
 cc -c "-DVAR=?test?" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=?test?" foo.c -o foo.o >/dev/null 2>&1
= trying: "'" quoting
= passed: mkdir .libs
 cc -c "-DVAR='test'" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR='test'" foo.c -o foo.o >/dev/null 2>&1
= trying: " " quoting
= passed: mkdir .libs
 cc -c "-DVAR= test " foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR= test " foo.c -o foo.o >/dev/null 2>&1
= trying: "     " quoting
= passed: mkdir .libs
 cc -c "-DVAR=  test    " foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=  test    " foo.c -o foo.o >/dev/null 2>&1
== link mode
= trying: no quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,-someflag=test foo.o 
= trying: \\ quoting
= failed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=\\test\\" foo.o 
= trying: \" quoting
= failed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=\"test\"" foo.o 
= trying: \` quoting
= failed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=\`test\`" foo.o 
= trying: \$ quoting
= failed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=\$test\$" foo.o 
= trying: "[" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=[test[" foo.o 
= trying: "]" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=]test]" foo.o 
= trying: "~" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=~test~" foo.o 
= trying: "#" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=#test#" foo.o 
= trying: "^" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=^test^" foo.o 
= trying: "&" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=&test&" foo.o 
= trying: "*" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=*test*" foo.o 
= trying: "(" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=(test(" foo.o 
= trying: ")" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=)test)" foo.o 
= trying: "{" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag={test{" foo.o 
= trying: "}" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=}test}" foo.o 
= trying: "|" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=|test|" foo.o 
= trying: ";" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=;test;" foo.o 
= trying: "<" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=<test<" foo.o 
= trying: ">" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=>test>" foo.o 
= trying: "?" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=?test?" foo.o 
= trying: "'" quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag='test'" foo.o 
= trying: " " quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag= test " foo.o 
= trying: "     " quoting
= passed: mkdir .libs
cc -o hell -g -O -Wl,"-someflag=        test    " foo.o 
== install mode
= trying: no quoting
= passed: install -c --something=test hell /usr/local/bin/hell
= trying: \\ quoting
= failed: install -c "--something=\\test\\" hell /usr/local/bin/hell
= trying: \" quoting
= failed: install -c "--something=\"test\"" hell /usr/local/bin/hell
= trying: \` quoting
= failed: install -c "--something=\`test\`" hell /usr/local/bin/hell
= trying: \$ quoting
= failed: install -c "--something=\$test\$" hell /usr/local/bin/hell
= trying: "[" quoting
= passed: install -c "--something=[test[" hell /usr/local/bin/hell
= trying: "]" quoting
= passed: install -c "--something=]test]" hell /usr/local/bin/hell
= trying: "~" quoting
= passed: install -c "--something=~test~" hell /usr/local/bin/hell
= trying: "#" quoting
= passed: install -c "--something=#test#" hell /usr/local/bin/hell
= trying: "^" quoting
= passed: install -c "--something=^test^" hell /usr/local/bin/hell
= trying: "&" quoting
= passed: install -c "--something=&test&" hell /usr/local/bin/hell
= trying: "*" quoting
= passed: install -c "--something=*test*" hell /usr/local/bin/hell
= trying: "(" quoting
= passed: install -c "--something=(test(" hell /usr/local/bin/hell
= trying: ")" quoting
= passed: install -c "--something=)test)" hell /usr/local/bin/hell
= trying: "{" quoting
= passed: install -c "--something={test{" hell /usr/local/bin/hell
= trying: "}" quoting
= passed: install -c "--something=}test}" hell /usr/local/bin/hell
= trying: "|" quoting
= passed: install -c "--something=|test|" hell /usr/local/bin/hell
= trying: ";" quoting
= passed: install -c "--something=;test;" hell /usr/local/bin/hell
= trying: "<" quoting
= passed: install -c "--something=<test<" hell /usr/local/bin/hell
= trying: ">" quoting
= passed: install -c "--something=>test>" hell /usr/local/bin/hell
= trying: "?" quoting
= passed: install -c "--something=?test?" hell /usr/local/bin/hell
= trying: "'" quoting
= passed: install -c "--something='test'" hell /usr/local/bin/hell
= trying: " " quoting
= passed: install -c "--something= test " hell /usr/local/bin/hell
= trying: "     " quoting
= passed: install -c "--something=      test    " hell /usr/local/bin/hell
FAIL: quote.test
====================================
1 of 1 tests failed
Please report to address@hidden
====================================
gmake[2]: *** [check-TESTS] Error 1
gmake[2]: Leaving directory `/usr/local/src/gnu/libtool-1.5/build/tests'
gmake[1]: *** [check-am] Error 2
gmake[1]: Leaving directory `/usr/local/src/gnu/libtool-1.5/build/tests'
gmake: *** [check-recursive] Error 1
address@hidden 15% 
-----------< end "make check TESTS=quote.test VERBOSE=x" >------------
: 
: *snip*
: > : Content-Description: branch-1-5-uw.patch
: > [snip]
: > : > @@ -2314,11 +2327,11 @@
: > : >    lt_cv_deplibs_check_method=pass_all
: > : >    ;;
: > : >  
: > : > -sysv5OpenUNIX8* | sysv5UnixWare7* | sysv5uw[[78]]*)
: > : > +sysv5*)
: > : >    lt_cv_deplibs_check_method=pass_all
: > : >    ;;
: > : >  
: > : > -sysv4 | sysv4.2uw2* | sysv4.3* | sysv5*)
: > : > +sysv4 | sysv4.2uw2* | sysv4.3*)
: > : >    case $host_vendor in
: > : >    motorola)
: > : >      lt_cv_deplibs_check_method='file_magic ELF [[0-9]][[0-9]]*-bit 
[[ML]]SB (shared object|dynamic lib) M[[0-9]][[0-9]]* Version [[0-9]]'
: > : > @@ -2339,10 +2352,13 @@
: > : >    siemens)
: > : >      lt_cv_deplibs_check_method=pass_all
: > : >      ;;
: > : > +  pc)
: > : > +    lt_cv_deplibs_check_method=pass_all
: > : > +    ;;
: > : >    esac
: > : >    ;;
: > : >  
: > : > -sysv4*uw2* | unixware7*)
: > : > +unixware7*)
: > : 
: > : Now, this macro doesn't have a match for sysv4*uw2* any more.  Is this
: > : intentional?
: > 
: > Quite intentional. Look at the case above, it already had sysv4*uw2* so
: > the one I removed would never have been used anyway. Adding the "pc)"
: > case to the $host_vendor part did what the other case was supposed to do.
: 
: Erm, it had sysv4.2uw2* but not sysv4*uw2*.  If both should be treated
: similarly here, then you should replace the former with the latter (in
: the line where sysv4 is also matched)

Remind me never to take a proof reading job. I guess my brain was focusing
in the uw2 part.
All UnixWare 2.x versions (and 1.x) are sysv4.2, so the sysv4*uw2 entry
becomes redundant.

: 
: > It could be cleanded up further by having "sysv5* | unixware7*)".
: > (UnixWare 7 is sysv5)
: 
: Hmm, then both of those should be treated similarly, I guess?

Yes.

: > I assume that unixware7* is in there for backward compatibility for
: > some old config.guess.
: 
: I have no idea, really.
: 
: > : 
: > : >    lt_cv_deplibs_check_method=pass_all
: > : >    ;;
: > : >  esac
[snip]
: 
: Cheers, and thanks again,
: Ralf
: 
: 

-- 
Tim Rice                                Multitalents    (707) 887-1469
address@hidden