Re: [patch 05/19] 288-gary-ltdl-nonrecursive-tests.diff Queue

[Ralf Wildenhues]

Ho Gary,

* Gary V. Vaughan wrote on Fri, Oct 14, 2005 at 05:30:39PM CEST:
> Ralf Wildenhues wrote:
> >See nits below, and this one: all of them FAIL with 2.59/1.9.6 (without
> >libobjdir fixes):
> >
> >[...]
> >| configure.ac:11: required file `./lt__dirent.c' not found
> >| configure.ac:11: required file `./argz.c' not found
> >| configure.ac:11: required file `./lt__strl.c' not found
> >| Makefile.am: installing `libltdl/config/depcomp'
> >| autoreconf: automake failed with exit status: 1
> >
> >Can you make them SKIP in this case, so we don't get oodles of bogus bug
> >reports?
> 
> No need.  Fixed the tests to work irrespective of SUBDIR_LIBOBJS support.

Great, thanks.  Guess we need to document this (version requirement
and/or workaround).

> >>and surely AC_PROG_CC should come before AM_INIT_AUTOMAKE?
> >
> >Not at all, why?  INIT sounds like: do this first.  Right?
> >Sounds right to me.  Everything that has to become before this _needs_
> >to be documented very explicitly.  Quoting automake.info (Complete):
> 
> Done.

Merci.

> Okay to commit?

Yes, please, after addressing these two nits:
- accommodate for Makefile.inc changes (AM_CPPFLAGS and AM_LDFLAGS)
- having installed 293 first.

Thanks!
Ralf

>  Makefile.am           |    1
>  tests/nonrecursive.at |  150 
>  ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/testsuite.at    | 
>  9 +++
>  3 files changed, 160 insertions(+)
> 
> Index: libtool--devo--1.0/ChangeLog
> from  Gary V. Vaughan  <address@hidden>
>         * tests/nonrecursive.at: New tests for libltdl as a subdirectory,
>         configured and compiled from the toplevel project.
>         * tests/testsuite.at: Use it.
>         (LT_AT_AUTOHEADER): New macro.
>         * Makefile.am (TESTSUITE_AT): Depend on nonrecursive.at.