libtoolize --ltdl non-failure (was: [O-MPI devel] ppc64 linux bustage?)

[Ralf Wildenhues]

[ This is a bug reported against Debian libtool/libltdl packages,
  uncovered in OpenMPI; see here:
  http://www.open-mpi.org/community/lists/devel/2005/10/0487.php
  It affects Debian packages, Libtool CVS branch-1-5, and CVS HEAD.
  For followups, please remove address@hidden (subscribers only).
]

> * Troy Benjegerdes wrote on Sat, Oct 29, 2005 at 08:01:08AM CEST:
>
[ reported this: ]

* Ralf Wildenhues wrote on Sat, Oct 29, 2005 at 10:38:11AM CEST:
> It's a bug when
>   libtoolize --ltdl
> succeeds although it did not find the libltdl source files.

To reproduce: uninstall libtldl3-dev on Debian, then see above command
still succeeding; alternatively, just move `$pkgdatadir/libltdl'
somewhere else after `make install'.  I'm uncertain whether Debian's
packaging needs a change, though.

In any case, OK to apply the patch below to branch-1-5?

Gary, could you look into a fix for CVS HEAD?  The corresponding code
looks a bit nonobvious to me.

Cheers,
Ralf

        * libtoolize.in: Fail if libltdl files not present but
        `--ltdl' given.
        Reported by Troy Benjegerdes <address@hidden>.

Index: libtoolize.in
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/libtoolize.in,v
retrieving revision 1.21.2.13
diff -u -r1.21.2.13 libtoolize.in
--- libtoolize.in       22 Apr 2005 09:05:40 -0000      1.21.2.13
+++ libtoolize.in       29 Oct 2005 09:01:33 -0000
@@ -281,6 +281,10 @@
 if test "x$ltdl" = xyes; then
   test -d libltdl || $mkdir libltdl
   ltdlfiles=`cd $pkgdatadir && ls libltdl/*`
+  if test -z "$ltdlfiles"; then
+    echo "$progname: cannot list files in \`$pkgdatadir/libltdl'" 1>&2
+    exit 1
+  fi
 else
   ltdlfiles=
 fi