libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

HEAD: Makefile woes (2/n)


From: Ralf Wildenhues
Subject: HEAD: Makefile woes (2/n)
Date: Sun, 5 Feb 2006 18:26:11 +0100
User-agent: Mutt/1.5.9i

Weird though that the recent simplification of testsuite mention of
dependent files actually has a small problem: `testsuite' is not always
rebuilt when it should be: for example when you undo a patch adding a
new testsuite file, only Makefile.am will be changed, but testsuite will
not be rebuilt.  Or you add a new test, but `testsuite' has been
regenerated recently and its timestamp is newer than that of the new
test.

The most correct solution would be to have `tests/testsuite' depend on
Makefile.am.  This is heavy in many unnecessary cases, however.
Alternatively, we could just force a rebuild in `bootstrap'.  Or have
it depend on Makefile.am, but with a witness file somehow.  Can somebody
come up with a better patch than the one below that works in all cases
but does not rebuild quite as often?

Cheers,
Ralf

        * Makefile.am ($(TESTSUITE)): Also depend on `Makefile.am'.

Index: Makefile.am
===================================================================
RCS file: /cvsroot/libtool/libtool/Makefile.am,v
retrieving revision 1.191
diff -u -r1.191 Makefile.am
--- Makefile.am 5 Feb 2006 17:12:52 -0000       1.191
+++ Makefile.am 5 Feb 2006 17:25:45 -0000
@@ -427,7 +427,7 @@
 
 # Use `$(srcdir)' for the benefit of non-GNU makes: this is
 # how `testsuite' appears in our dependencies.
-$(srcdir)/$(TESTSUITE): $(srcdir)/tests/package.m4 $(TESTSUITE_AT)
+$(srcdir)/$(TESTSUITE): $(srcdir)/tests/package.m4 $(TESTSUITE_AT) Makefile.am
        cd $(srcdir)/tests && \
        $(AUTOTEST) `echo $(TESTSUITE_AT) | sed 's,tests/,,g'` -o testsuite
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]