Re: HEAD link-order.at fails when hardcode_direct=yes

[Gary V. Vaughan]

Ralf Wildenhues wrote:
> Hi Albert, Gary,

Howdy!

> * Albert Chin wrote on Wed, May 17, 2006 at 02:44:49PM CEST:
>
> > +  case $hardcode_direct$hardcode_direct_static in
> > +  yesno)
> > +    AT_CHECK([if $EGREP relinking stderr; then
> > +               $EGREP " .*\/new\/lib/libb$shrext_cmds 
> > .*\/old\/lib/libcee$shrext_cmds" stdout
> > +             else :; fi], [0], [ignore], [], [echo "wrong link order"])
> > +    ;;
>
> You shouldn't grep for $shrext_cmds.  It's called *_cmds because it may
> contain commands.  The right way is to
>   module=no
>   eval shared_ext=\"$shrext_cmds\"

Oops.  Should've spotted that myself.  I'll fix that presently too.

> * Gary V. Vaughan wrote on Wed, May 17, 2006 at 04:34:44PM CEST:
>
> > > 2006-05-16  Albert Chin-A-Young  <address@hidden>
> > >
> > >         * tests/link-order.at: Take hardcode_direct and
> > >         hardcode_direct_static into consideration when testing
> > >         link order.
> >
> > Thanks.  Applied both this change and the linked patch.
>
>
> Thanks.  Are you volunteering for the backport to branch-1-5 (which has
> a similar issue) or should I do it?

Luckily, in my reply to your next email we've agreed that it doesn't
need a backport. ;-)

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://blog.azazil.net
GNU Hacker           / )=   http://trac.azazil.net/projects/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook