libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch-1-5: assume AIX compiler understands ##


From: Ralf Wildenhues
Subject: branch-1-5: assume AIX compiler understands ##
Date: Wed, 7 Feb 2007 00:10:10 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On AIX 4.3.3, building branch-1-5 fails because configure selects
-qlanglvl=extc89, but that in turn causes __STDC__ not to be defined
(unlike without -qlanglvl=extc89, or with -qlanglvl=stdc89 instead).
And of course the build then fails because /**/ isn't recognized as
string concatenator.

I tested building branch-1-5 with CVS Autoconf, which causes the flag
to be selected, but I think Autoconf-2.61 does that as well.  (Not sure
whether this can be considered an Autoconf bug.)

Anyway, I'm not totally sure whether the patch below is the right thing
to do.  But since `defined (__STDC__) || defined (_AIX)' is used in a
number of places in ltdl.h, I guess it's good enough, so I applied it.
I'd appreciate comments though.

For HEAD this isn't an issue, since we assume C89 there.

Cheers,
Ralf

2007-02-06  Ralf Wildenhues  <address@hidden>

        * libltdl/ltdl.h (LT_CONC) [_AIX]: Use `##'.  AIX 4.3.3 xlc
        won't define __STDC__ with -qlanglvl=extc89.

Index: libltdl/ltdl.h
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/ltdl.h,v
retrieving revision 1.57.2.6
diff -u -r1.57.2.6 ltdl.h
--- libltdl/ltdl.h      28 Jan 2007 13:40:49 -0000      1.57.2.6
+++ libltdl/ltdl.h      6 Feb 2007 23:00:11 -0000
@@ -79,7 +79,7 @@
 
 /* LT_CONC creates a new concatenated symbol for the compiler
    in a portable way.  */
-#if defined(__STDC__) || defined(__cplusplus) || defined(_MSC_VER)
+#if defined(__STDC__) || defined(__cplusplus) || defined(_MSC_VER) || 
defined(_AIX)
 #  define LT_CONC(s,t) s##t
 #else
 #  define LT_CONC(s,t) s/**/t




reply via email to

[Prev in Thread] Current Thread [Next in Thread]