[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cygwin] cwrapper emits wrapper script
From: |
Peter O'Gorman |
Subject: |
Re: [cygwin] cwrapper emits wrapper script |
Date: |
Wed, 06 Jun 2007 23:17:58 -0500 |
On Wed, 2007-06-06 at 10:25 -0400, Charles Wilson wrote:
> Peter O'Gorman wrote:
> > Could you please resend the patch itself, I am having issues with
> > stripping the html markup from these links. (well, I can strip the html,
> > but the resulting patch is not applying.)
>
> Attached.
>
> --
> Chuck
>
> 2007-04-27 Charles Wilson <address@hidden>
>
> * ltmain.m4sh (func_emit_libtool_wrapper_script): add
> code block to handle cases when wrapper script is in $objdir.
> (func_emit_libtool_cwrapperexe_source): replace DEBUG() macro
> with namespace-safe LTWRAPPER_DEBUGPRINTF(). Call
> func_emit_libtool_wrapper_script() with appropriate filters to
> embed script text in C char* static variable.
> (f_e_l_c_s: main): add new option --lt-dump-script, parse argv[]
> for it, and take appropriate action. Call chase_symlinks()
> on argv[0], in case this.exe was launched via one. Use chased
> value to determine full absolute pathname of wrapper script, in
> $objdir. Unconditionally write script out to this pathname and
> set permission bits. Remove extraneous ';' from debugging loop.
> (f_e_l_c_s: main) [mingw]: DOS-ize $SHELL before populating
> newargv[0]; if $TARGETSHELL environment variable is set, use
> it instead of $SHELL and do not DOS-ize. Ensure newargv[1]
> (wrapper script absolute path) uses only '/', not '\'. Make
> sure to call execv() with DOS-ized $SHELL (or un-DOS-ized
> $TARGETSHELL, if set)
> (f_e_l_c_s: make_executable): new function
> (f_e_l_c_s: chase_symlinks): new function (no-op if !S_ISLNK)
>
> 2007-04-27 Charles Wilson <address@hidden>
>
> * ltmain.m4sh (func_emit_libtool_cwrapperexe_source):
> ensure that generated source follows GCS as nearly as
> possible.
>
Ok. Causes no regressions for me on linux or darwin, and nothing jumps
out at me, please feel free to exercise your commit bit on these :-)
I am not, unfortunately, able to test on windows.
Noah gave a good suggestion about passing
WRAPPER_SCRIPT_BELONGS_IN_OBJDIR as an argument, but, I agree, it can be
left to a later patch.
At some point it would be nice to emit
func_emit_libtool_cwrapperexe_source from config.status, saving 550
lines of code from libtool on non-windows platforms. But I'm just
dreaming, you can ignore that :)
Thank you!
Peter
- Re: [cygwin] cwrapper emits wrapper script, (continued)
- Re: [cygwin] cwrapper emits wrapper script, Noah Misch, 2007/06/01
- Re: [cygwin] cwrapper emits wrapper script, Gary V. Vaughan, 2007/06/03
- Re: [cygwin] cwrapper emits wrapper script, Peter O'Gorman, 2007/06/06
- Re: [cygwin] cwrapper emits wrapper script, Eric Blake, 2007/06/07
- Re: [cygwin] cwrapper emits wrapper script, Eric Blake-1, 2007/06/07