Hopefully the attached addresses all of the concerns mentions by Noah, Erick,
and Peter with regards to my recent cwrapper-emits-shwrapper patch.
Tested on cygwin, mingw, and linux with no regressions from
http://lists.gnu.org/archive/html/libtool-patches/2007-04/msg00088.html
although, as expected, the new lt_dlopenadvise test fails on both cygwin and
mingw.
Recapping those test results (and some test numbers have changed)
___________________________________________________________
cygwin
======================
All 115 tests passed
(9 tests were not run)
======================
14: Java convenience archives FAILED (convenience.at:273)
16: Link order of deplibs. FAILED (link-order2.at:129)
32: lt_dlopenadvise library loading FAILED (lt_dladvise.at:316)
54: Run tests with low max_cmd_len FAILED (cmdline_wrap.at:43)
This is the expected output, for now.
___________________________________________________________
mingw
======================
All 115 tests passed
(9 tests were not run)
======================
14: Java convenience archives FAILED (convenience.at:273)
16: Link order of deplibs. FAILED (link-order2.at:129)
26: DESTDIR with in-package deplibs FAILED (destdir.at:131)
32: lt_dlopenadvise library loading FAILED (lt_dladvise.at:314)
35: installable libltdl FAILED (standalone.at:69)
39: installable libltdl FAILED (subproject.at:99)
43: installable libltdl FAILED (nonrecursive.at:143)
46: installable libltdl FAILED (recursive.at:113)
54: Run tests with low max_cmd_len FAILED (cmdline_wrap.at:43)
14/16/51 are the same as cygwin.
32 expected on win32
35/39/43/46 appear to be due to msys trying to execute "INSTALL" as if it
were install.exe.
Not sure about 26.
None of these errors represent regressions on this platform.
___________________________________________________________
Linux
====================
All 106 tests passed
====================
52 tests behaved as expected.
2 tests were skipped.
___________________________________________________________
Changelog:
2007-06-08 Charles Wilson <...>
* ltmain.m4sh (func_emit_libtool_wrapper_script):
take an argument to specify value assigned to
WRAPPER_SCRIPT_BELONGS_IN_OBJDIR in the emitted
script.
(func_emit_libtool_cwrapperexe_source) [file scope]:
define permission flags S_IXGRP and S_IXOTH if not
already defined.
(func_emit_libtool_cwrapperexe_source) [LTWRAPPER_DEBUGPRINTF]:
declare as a function, not a macro, as variadic macros
are not supported by C89.
(func_emit_libtool_cwrapperexe_source) [check_executable]:
avoid embedded #ifdefs; use S_IXGRP and S_IXOTH
unconditionally.
(func_emit_libtool_cwrapperexe_source) [make_executable]:
ditto.
(func_emit_libtool_cwrapperexe_source): don't rewrite
WRAPPER_SCRIPT_BELONGS_IN_OBJDIR posthoc; instead pass
correct argument when calling func_emit_libtool_wrapper_script.
(func_mode_link): pass correct argument when calling
func_emit_libtool_wrapper_script.
--
Chuck