Re: Using getconf to set max_cmd_len

[Charles Wilson]

Ralf Wildenhues wrote:
> * Steve Ellcey wrote on Thu, May 31, 2007 at 12:58:37AM CEST:
> > 2007-05-30  Steve Ellcey  <address@hidden>
> >
> >         * libltdl/m4/libtool.m4 (LT_CMD_MAX_LEN): Try using getconf
> >         to set lt_cv_sys_max_cmd_len.
> [...]
>
> > +    lt_cv_sys_max_cmd_len=`getconf ARG_MAX 2> /dev/null`
>
> The patch is all good (thanks!) except someone please put `getconf
> ARG_MAX' in a subshell so that if it does not exist, the shell error
> output is redirected as well (both branches).

OK to apply (both branches)?

2007-06-17  Charles Wilson  <...>
            Ralf Wildenhues  <...>

        * libltdl/m4/libtool.m4 (LT_CMD_MAX_LEN): ensure error is
        redirected even when getconf does not exist.

--
Chuck

? .signature
Index: libltdl/m4/libtool.m4
===================================================================
RCS file: /sources/libtool/libtool/libltdl/m4/libtool.m4,v
retrieving revision 1.105
diff -u -r1.105 libtool.m4
--- libltdl/m4/libtool.m4       4 Jun 2007 03:01:11 -0000       1.105
+++ libltdl/m4/libtool.m4       17 Jun 2007 18:23:24 -0000
@@ -1437,7 +1437,7 @@
     fi
     ;;
   *)
-    lt_cv_sys_max_cmd_len=`getconf ARG_MAX 2> /dev/null`
+    lt_cv_sys_max_cmd_len=`(getconf ARG_MAX) 2> /dev/null`
     if test -n $lt_cv_sys_max_cmd_len; then
       lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \/ 4`
       lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \* 3`

Index: libtool.m4
===================================================================
RCS file: /sources/libtool/libtool/Attic/libtool.m4,v
retrieving revision 1.314.2.179
diff -u -r1.314.2.179 libtool.m4
--- libtool.m4  4 Jun 2007 03:28:27 -0000       1.314.2.179
+++ libtool.m4  17 Jun 2007 18:25:33 -0000
@@ -794,7 +794,7 @@
     fi
     ;;
   *)
-    lt_cv_sys_max_cmd_len=`getconf ARG_MAX 2> /dev/null`
+    lt_cv_sys_max_cmd_len=`(getconf ARG_MAX) 2> /dev/null`
     if test -n $lt_cv_sys_max_cmd_len; then
       lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \/ 4`
       lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \* 3`