libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HEAD: fix lt_dlloader_remove memleak in libltdl


From: Eric Blake
Subject: Re: HEAD: fix lt_dlloader_remove memleak in libltdl
Date: Sat, 01 Sep 2007 06:33:19 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 9/1/2007 4:46 AM:
> Index: libltdl/lt_dlloader.c
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/libltdl/lt_dlloader.c,v
> retrieving revision 1.11
> diff -u -r1.11 lt_dlloader.c
> --- libltdl/lt_dlloader.c     4 Jul 2007 23:05:04 -0000       1.11
> +++ libltdl/lt_dlloader.c     1 Sep 2007 10:02:00 -0000
> @@ -142,17 +142,28 @@
>    return (const lt_dlvtable *) (loader ? ((SList *) loader)->userdata : 0);
>  }
>  
> +/* Callback function to iterate over all handles */
> +static int
> +find_all_handles (lt_dlhandle LT__UNUSED handle, const char * LT__UNUSED id)
> +{
> +  return 0;
> +}

Either we should expose this function, or it is not necessary.  I
remembered that at one point, we had to fix loaders/loadlibrary.c to do
something similar in iterating over all modules, but looking closer,
get_vtable registers with a NULL callback.  In fact, lt_dlhandle_iterate
special cases a NULL filter callback to visit everything.  But the
documentation in libtool.texi does not mention that.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG2VwP84KuGfSFAYARApYHAJ4o5tm6LalJiSljMafTrQ96BVnh4wCfYFGp
bfAXB3pcoWXOPz9JJbKEmUk=
=zxrr
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]