Re: [PATCH 370] Implement lt_dlopening of only preloaded modules.

[Gary V. Vaughan]

On 6 May 2008, at 14:07, Ralf Wildenhues wrote:
> Hi Gary,

Hallo Ralf,

> a quick nit review (I haven't looked thoroughly yet):

Thanks.  I'll fix these nits and repost an updated [PATCH 370 bis]  
shortly.  I'm only commenting on the nits I disagree with here.   
Everything else will be addressed in the repost.

> * Gary V. Vaughan wrote on Tue, May 06, 2008 at 07:24:46PM CEST:
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -2,9 +2,10 @@ NEWS - list of user-visible changes between  
> > releases of GNU Libtool
> >
> > New in 2.2.??: 2008-06-??: git version 2.2.5a, Libtool team:
> >
> > -* Bug fixes:
> > +* New features:
> >
> > -  - None yet
>
> No need to remove the Bug fixes section, there will certainly be  
> entries
> later, no?  ;-)

What? Bugs in libtool?  Of course not!!

But seriously, that was a spurious place-holder when I added the git  
version 2.2.5a line, to stop it looking lonely :-)  No need for the  
place-holder now that we have some real information there.

> > --- a/libltdl/m4/ltdl.m4
> > +++ b/libltdl/m4/ltdl.m4
> > @@ -264,7 +264,7 @@ if test "x$with_included_ltdl" != xyes; then
> >   # decide whether there is a useful installed version we can use.
> >   AC_CHECK_HEADER([ltdl.h],
> >       [AC_CHECK_DECL([lt_dlinterface_register],
> > -          [AC_CHECK_LIB([ltdl], [lt_dlinterface_register],
> > +          [AC_CHECK_LIB([ltdl], [lt_dladvise_preload],
> >                [with_included_ltdl=no],
> >                [with_included_ltdl=yes])],
> >            [with_included_ltdl=yes],
>
> I view this as a separate change.

I disagree at the moment, but I'm glad you brought it up, as I went  
back and forth on it myself for a while...

> Not sure whether we should have a
> policy to always require the newest available feature or not, in an
> installed ltdl.

My reasoning is that if you have libtoolized your package with a  
particular set of ltdl.m4 et al and you read the associated info  
manual on libltdl features, there is every chance that you will have  
used that newest available feature.  Without explicitly checking which  
features are actually used by the parent project, the best we can  
offer is to require that everything up to and including that newest  
feature is available from the installed libltdl before we decide to  
use it in preference to the shipped libltdl.

That being the case, updating ltdl.m4 to do that correctly is very  
much a part of a patch that adds a new libltdl entry point.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_

PGP.sig
Description: This is a digitally signed message part