[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [mingw] fix cross-compile-with-wine case
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] [mingw] fix cross-compile-with-wine case |
Date: |
Sun, 1 Jun 2008 09:12:45 +0200 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
Hi Charles,
* Charles Wilson wrote on Sat, May 31, 2008 at 07:11:58PM CEST:
> * libltdl/config/ltmain.m4sh (func_to_host_path)
> [host=mingw, build!=mingw|cygwin]: check that winepath
> stdout is non-empty and exit code is 0, instead of checking
> stderr.
> Reported by: Roumen Petrov
OK, thanks!
> --- a/libltdl/config/ltmain.m4sh
> +++ b/libltdl/config/ltmain.m4sh
> @@ -2555,17 +2555,21 @@ func_to_host_path ()
> + func_to_host_path_tmp1=`winepath -w "$1" 2>/dev/null`
> func_to_host_path_winepath_exitcode=$?
> if test "$func_to_host_path_winepath_exitcode" -eq 0 &&\
[...]
> + test -n "${func_to_host_path_tmp1}" ; then
You could simplfify these four lines to
func_to_host_path_tmp1=`winepath -w "$1" 2>/dev/null`
if test $? -eq 0 && test -n "${func_to_host_path_tmp1}"; then
if the exit status isn't important to you for debugging purposes.
Cheers,
Ralf
- Re: [PATCH] [mingw] fix cross-compile-with-wine case,
Ralf Wildenhues <=