libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix ltmain.sh


From: Eric Blake
Subject: Re: Fix ltmain.sh
Date: Fri, 19 Dec 2008 06:10:21 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18) Gecko/20081105 Thunderbird/2.0.0.18 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Akim Demaille on 12/19/2008 3:47 AM:
> I'm a contributor to GNU Libtool, and proud of it!

Indeed, with copyright assignment since 2001!

>  Please find attached
> a patch fixing a critical bug.

Can you convince your mailer to send patches with a text MIME type,
instead of application/octet-stream?  It makes reviewing a lot easier when
patches can be read inline, instead of having to save them off to another
file.

>  Don't forget to credit me in THANKS ;)

You are already there ;)

At any rate, this patch looks sensible, except that while we are adjusting
the line, we might as well wrap to fit in 80 columns.  And we need a
ChangeLog entry.  I'm pushing this:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklLnT0ACgkQ84KuGfSFAYAo/QCgiW1fexO8gShA7IRA3ANH+f18
rhoAniE5mBflzJdrx6y+lzJJOK3Zndfh
=FeoZ
-----END PGP SIGNATURE-----
>From 756f95dd608704d2327929412a9a023ca822a079 Mon Sep 17 00:00:00 2001
From: Akim Demaille <address@hidden>
Date: Fri, 19 Dec 2008 11:45:05 +0100
Subject: [PATCH] Fix copyright notice.

* libltdl/config/ltmain.m4sh: Add missing comma.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog                  |    5 +++++
 libltdl/config/ltmain.m4sh |    5 +++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ce3b324..65eef10 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-12-19  Akim Demaille  <address@hidden>
+
+       Fix copyright notice.
+        * libltdl/config/ltmain.m4sh: Add missing comma.
+
 2008-12-17  Ralf Wildenhues  <address@hidden>
 
        Add cache variables to link tests.
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 2769149..20ca07b 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -4,7 +4,8 @@ m4_divert_push([SCRIPT])# @configure_input@
 # libtool (GNU @PACKAGE@@TIMESTAMP@) @VERSION@
 # Written by Gordon Matzigkeit <address@hidden>, 1996
 
-# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005, 2006, 
2007 2008 Free Software Foundation, Inc.
+# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005,
+# 2006, 2007, 2008 Free Software Foundation, Inc.
 # This is free software; see the source for copying conditions.  There is NO
 # warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
@@ -455,7 +456,7 @@ $opt_help || {
 # determined imposters.
 func_lalib_p ()
 {
-    test -f "$1" && 
+    test -f "$1" &&
       $SED -e 4q "$1" 2>/dev/null \
         | $GREP "^# Generated by .*$PACKAGE" > /dev/null 2>&1
 }
-- 
1.6.0.4


reply via email to

[Prev in Thread] Current Thread [Next in Thread]