Re: [PATCH] Add tests for cwrapper with -std=c89 and -std=c99

[Ralf Wildenhues]

* Charles Wilson wrote on Fri, Jan 23, 2009 at 12:36:57AM CET:
> * tests/cwrapper.at: New file.
> * Makefile.am: Add tests/cwrapper.at.
> ---
> Ok to push?

Yes, with really minor nits:

> --- /dev/null
> +++ b/tests/cwrapper.at
> @@ -0,0 +1,81 @@

> +AT_SETUP([wrapper for uninstalled dynamically linked executables - C])

This message is a bit long, and thus will look ugly in the test output.
How about just
  cwrapper for uninstalled executables

so that we can use "cwrapper" as keyword for choosing this test;
it should be specific enough to tell users what it is about (and
it doesn't matter here whether this wrapper is for some form of
linking only).

> +orig_CFLAGS=$CFLAGS
> +orig_LIBTOOL=$LIBTOOL
> +for restrictive_flags in '-std=c89 -Werror' '-std=c99 -Werror'; do
> +  CFLAGS="$orig_CFLAGS $restrictive_flags"
> +  sed "s/LTCFAGS=.*/&' $restrictive_flags'/" < "$orig_LIBTOOL" > ./libtool
> +  LIBTOOL=./libtool
> +
> +  # make sure $restrictive_flags do not cause a failure
> +  # themselves (e.g. because a non-gcc compiler doesn't them)

s/them)/understand &/

> +  $LIBTOOL --mode=compile $CC $CPPFLAGS $CFLAGS -c trivial.c || continue

Please go ahead and push with these changes.

Thank you,
Ralf