[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix bindir and dlopen tests for C++ compilers (CC=g++).
From: |
Peter O'Gorman |
Subject: |
Re: Fix bindir and dlopen tests for C++ compilers (CC=g++). |
Date: |
Sun, 29 Nov 2009 22:15:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 |
On 11/29/2009 04:12 PM, Ralf Wildenhues wrote:
I've built Libtool and run the testsuites with CC=g++ on GNU/Linux,
the following patch fixes the fallout. Pushed as obvious.
You did 'make check CC=g++'? or './configure CC=g++; make; make check'?
IIRC libltdl itself did not built for me with make distcheck CC=g++ not
because of test suite failures, but because libltdl itself fails to build.
A simple cast allows it to build:
diff --git a/libltdl/ltdl.c b/libltdl/ltdl.c
index 24ee13f..270d528 100644
--- a/libltdl/ltdl.c
+++ b/libltdl/ltdl.c
@@ -1511,7 +1511,7 @@ has_library_ext (const char *filename)
assert (filename);
- ext = strrchr (filename, '.');
+ ext = (char *)strrchr (filename, '.');
if (ext && ((streq (ext, archive_ext))
#if defined(LT_MODULE_EXT)
But, I think there were objections to adding random casts like this when
it came up before?
Anyway, thanks for fixing the testsuite failures with this :)
Peter
--
Peter O'Gorman
http://pogma.com
- Fix bindir and dlopen tests for C++ compilers (CC=g++)., Ralf Wildenhues, 2009/11/29
- Re: Fix bindir and dlopen tests for C++ compilers (CC=g++).,
Peter O'Gorman <=
- Re: Fix bindir and dlopen tests for C++ compilers (CC=g++)., Ralf Wildenhues, 2009/11/30
- Re: Fix bindir and dlopen tests for C++ compilers (CC=g++)., Peter O'Gorman, 2009/11/30
- Re: Fix bindir and dlopen tests for C++ compilers (CC=g++)., Bob Friesenhahn, 2009/11/30
- Re: Fix bindir and dlopen tests for C++ compilers (CC=g++)., Bob Friesenhahn, 2009/11/30
- Re: Fix bindir and dlopen tests for C++ compilers (CC=g++)., Peter Rosin, 2009/11/30
- Re: Fix bindir and dlopen tests for C++ compilers (CC=g++)., Ralf Wildenhues, 2009/11/30
- Re: Fix bindir and dlopen tests for C++ compilers (CC=g++)., Peter Rosin, 2009/11/30