Re: Error reporting should be improved

[Peter Rosin]

Den 2009-12-30 22:22 skrev Bob Friesenhahn:
> On Wed, 30 Dec 2009, Peter Rosin wrote:
> > Aha, you have misunderstood the patch, that's why we don't understand
> > each other. The patch does indeed allocate a buffer, that's the whole
> > point of sending the error message to lt_dladderror. The error message
> > is cached indefinitely inside lt_dladderror. In order to not grow that
>
> In what line of code is a string buffer allocated?  The only buffer 
> allocation I see is a REALLOC to increase the buffer which holds 
> diagnostic pointers.  Then the passed pointer is assigned directly to 
> the pointer at errindex without any allocation or string copy.

Oh, I knew I was too tired when I wrote that patch. You are of course
correct.

*blush*

Cheers,
Peter