libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enable runtime cwrapper debugging; add tests


From: Charles Wilson
Subject: Re: [PATCH] Enable runtime cwrapper debugging; add tests
Date: Sun, 21 Feb 2010 17:04:01 -0500
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

Ralf Wildenhues wrote:
> * Charles Wilson wrote on Sun, Feb 21, 2010 at 06:34:02AM CET:
>> So, open issues, to be addressed if necessary in additional patches:
>> 1) "(func) ..." ---> '"(%s) ...", __func__' ?
>> 2) chmod in cwrapper.at?
> 
> Naah, ignore both.  Thanks.
> 
> strerror(errno) can return NULL for unknown errors on some systems.
> Not sure this can happen in practice here, wrapping in nonnull () should
> be a safe stopgap however.  Patch to this end preapproved.

Pushed.

2010-02-21  Charles Wilson  <...>

        Guard against strerror()==NULL
        * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:main):
        Check return value of strerror() using nonnull().
        (func_emit_cwrapperexe_src:find_executable): Ditto.
        (func_emit_cwrapperexe_src:chase_symlinks): Ditto.

--
Chuck

Attachment: 0030-cwrapper-guard-null-strerror.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]