Re: [PATCH 1/4] libtoolize: use only space delimited file lists.

[Gary V. Vaughan]

Hi Peter,

On 7 Nov 2011, at 17:32, Peter Rosin wrote:
> Gary V. Vaughan skrev 2011-11-05 18:04:
>> This next series of patches simplifies both Makefile.am and libtoolize.m4sh
>> enough that manipulations of the file lists by libtoolize at install time
>> become managable enough to do a nice rewrite of the config->build-aux rename
>> patch that I'll get to next.
>> 
>> By itself, this one is obvious enough.  The rest of the series each tackles
>> one directory full of files and the various variables and functions used by
>> libtoolize to copy files around, and for Makefile.am to install.
>> 
>> As with the other series I posted today, I'll push all of these in 72 hours
>> or more - subject to any review comments or other issues that need to be
>> addressed first.
>> 
>> We don't install any files with whitespace in their file name,
>> so using colon delimited lists to make that possible was a
>> premature optimisation and an unneeded complication.
>> * libtoolize.m4sh (func_copy_some_files): Remove IFS twiddling,
>> and just pull space delimited files in a for loop idiomatically.
>> (func_massage_aclocal_DATA, func_install_pkgmacro_subproject)
>> (func_install_pkgmacro_parent, func_install_pkgmacro_files)
>> (func_massage_pkgltdl_files, func_massage_pkgconfig_files):
>> Append to file lists with space delimiter.
>> 
>> Signed-off-by: Gary V. Vaughan <address@hidden>
>> ---
>> libtoolize.m4sh |   44 +++++++++++++-------------------------------
>> 1 files changed, 13 insertions(+), 31 deletions(-)
>> 
>> diff --git a/libtoolize.m4sh b/libtoolize.m4sh
> 
> *snip*
> 
>> @@ -819,7 +811,7 @@ func_install_pkgmacro_subproject ()
>>       pkgmacro_header="putting macros in AC_CONFIG_MACRO_DIR, 
>> \`$subproject_macro_dir'."
>>     fi
>> 
>> -    func_copy_some_files "argz.m4:libtool.m4:ltdl.m4:$pkgmacro_files" \
>> +    func_copy_some_files "libtool.m4 ltdl.m4 $pkgmacro_files" \
> 
> You don't mention why it's ok to drop argz.m4, is the drop intentional
> or was argz.m4 just lost in the churn?

It was lost during the reordering of patches, nicely caught - thanks.

(Much fuurther along my patch queue I'm working on adding more gnulib modules
to minimise the amount of bespoke portability code maintained purely in Libtool,
including adoptinng gnulib's argz which changed that line too.)

Fixed in my queued patch before pushing tomorrow.

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)