[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_qu
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case. |
|
Date: |
Mon, 21 Nov 2011 09:15:09 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 11/21/2011 07:47 AM, Gary V. Vaughan wrote:
> Contrary to popular belief, Bourne shell does not resplit case
> expressions after expansion, so if there are no shell unquoted
> shell metacharacters or whitespace, the quotes are useless.
> @@ -568,7 +568,7 @@ func_resolve_sysroot ()
> # store the result into func_replace_sysroot_result.
> func_replace_sysroot ()
> {
> - case "$lt_sysroot:$1" in
> + case $lt_sysroot:$1 in
> ?*:"$lt_sysroot"*)
Likewise in the pattern expression; you could further change this to:
case $lt_sysroot:$1 in
?*:$lt_sysroot*)
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 5/7] syntax-check: fix violations and implement sc_useless_braces_in_variable_derefs., (continued)
Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var., Stefano Lattarini, 2011/11/21
Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case.,
Eric Blake <=
Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case., Gary V. Vaughan, 2011/11/25