Re: [PATCH 3/7] tests: migrate tests/sh.test checks to syntax-checks.

[Stefano Lattarini]

On Tuesday 22 November 2011, Gary V wrote:
> Hi Stefano,
> 
> On 22 Nov 2011, at 02:52, Stefano Lattarini wrote:
> > Hi Gary.  Just a quick nit (I haven't looked at the whole
> > series, and not even at the whole patch in fact; sorry).
> 
> No apologies necessary, every little helps!  Thank you.
> 
> > On Monday 21 November 2011, Gary V wrote:
> >>    for file
> >>     do
> >> -      test -f $file || touch $file
> >> +      test -f "$file" || touch $file
> >> 
> > What's the point of quoting file after `test -f' it it remains
> > unquoted after `touch'?
> 
> Even though we know there is no whitespace in $file because of the
> for loop, there still might be other shell meta-characters in there.
> All uses of $file (including a bunch in the following lines) should
> be quoted correctly,
>
OK, good.

> but that is another patch.
> 
That's perfectly fine, but IMHO it should me mentioned in the commit
message.

Regards,
  Stefano