Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

[Peter Rosin]

On 2012-09-19 09:31, Peter Rosin wrote:
> * tests/runpath-in-lalib.at: Make sure shared libraries are created
> on Windows by passing -no-undefined. Otherwise libb.la fails to record
> a dependency on liba.la, and the final link of the program then fails
> with undefined symbols.
> 
> Signed-off-by: Peter Rosin <address@hidden>
> ---
>  tests/runpath-in-lalib.at |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Ok to push?
> Or maybe the failure is deeper than this? Should libb.la record a
> dependency on liba.la even if libb.la is static only?
> 
> The relevant difference in libb.la with this patch is this (I have
> elided changes to dlopen and library_names which are empty when
> no shared library is built):
> 
> @@ -17,7 +17,7 @@
>  inherited_linker_flags=''
>  
>  # Libraries that this one depends upon.
> -dependency_libs=' 
> -R/home/peda/libtool/git/cygwin/tests/testsuite.dir/047/foobar '
> +dependency_libs=' 
> -R/home/peda/libtool/git/cygwin/tests/testsuite.dir/047/foobar  
> /home/peda/libtool/git/cygwin/tests/testsuite.dir/047/liba.la'
>  
>  # Names of additional weak libraries provided by this library
>  weak_library_names=''

I likely is deeper, it seems this is a regression since 2.4.2.

Cheers,
Peter