libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch] Comments for linker-option section, was Re: powerpc*le-linux sup


From: Brooks Moses
Subject: [patch] Comments for linker-option section, was Re: powerpc*le-linux support
Date: Thu, 22 Aug 2013 15:52:23 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8

Gary, Peter -

First, thank you for helping get this committed!

On 08/22/2013 07:34 AM, Gary V. Vaughan wrote:
On Aug 22, 2013, at 8:58 PM, Peter Rosin <address@hidden> wrote:
How can it be correct to say "-m elf32lppclinux" (32-bit) when $host is
explicitly 64-bit? That seems like utter garbage to me. What am I
missing this time?

I don't get it either, and I can't test it.  I trust the ppcle community
will commence shouting if the patches have done something horrible. However,
if there is any nonsense here, it predates my recent patch butchering,
because even the pre-patched code seems to mix 32bit and 64bit concepts
liberally.

If someone would like to apply (or send me) a patch that adds a comment
explaining why this code needs to look so odd, that would be very helpful!

Based on Alan's explanation and what I could tell from looking at the code, I've tried to expand the comments to explain what's going on, as per the attached patch. Does this look like a useful improvement to the situation?

Thanks,
- Brooks

Attachment: 2013-08-22_ld-option-comments.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]