libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bad IFS initialisation breaks gcc build of libsanitizer


From: Alan Modra
Subject: Bad IFS initialisation breaks gcc build of libsanitizer
Date: Fri, 23 Aug 2013 21:54:34 +0930
User-agent: Mutt/1.5.21 (2010-09-15)

Putting tab first in IFS breaks func_echo_all usage of $*,
resulting in failure of func_infer_tag to match a command line using a
$CC with trailing spaces.  The trailing spaces were stripped out of
CC_expanded but words in $CC were separated by tabs.  This didn't
match the makefile expansion of $CC using the standard IFS with a
first char of space.

        * gl/build-aux/funclib.sh (IFS): Make first char a space.

diff --git a/gl/build-aux/funclib.sh b/gl/build-aux/funclib.sh
index 8a212d1..503b0ea 100644
--- a/gl/build-aux/funclib.sh
+++ b/gl/build-aux/funclib.sh
@@ -1,5 +1,5 @@
 # Set a version string for this script.
-scriptversion=2012-10-21.11; # UTC
+scriptversion=2013-08-23.10; # UTC
 
 # General shell script boiler plate, and helper functions.
 # Written by Gary V. Vaughan, 2004
@@ -82,7 +82,7 @@ done
 sp=' '
 nl='
 '
-IFS="  $sp$nl"
+IFS="$sp       $nl"
 
 # There are still modern systems that have problems with 'echo' mis-
 # handling backslashes, among others, so make sure $bs_echo is set to a

-- 
Alan Modra
Australia Development Lab, IBM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]