Re: [PATCH 2/2] libtool: set file_list_spec to '@' on OS/2

[Pavel Raiskup]

KO Myung-Hun, thanks for this patch but I need to see a bit deeper
reasoning for this change as I do not understand the code properly.

As the $file_list_spec is used in libtool under special circumstances, can
you describe what are the values of important variables (or could you post
a full libtool output with shell debugging output)?

Maybe other committers can help with the review?

Pavel



On Wednesday 16 of December 2015 12:59:17 KO Myung-Hun wrote:
> Creating and linking reloadable objects sometimes fail.
> 
> * m4/libtool.m4 (_LT_LINKER_SHLIBS, _LT_LANG_CXX_CONFIG) <os2-*>:
> Set file_list_spec to '@'.
> ---
>  m4/libtool.m4 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/m4/libtool.m4 b/m4/libtool.m4
> index 2e8c3cf..c01f8fb 100644
> --- a/m4/libtool.m4
> +++ b/m4/libtool.m4
> @@ -5169,6 +5169,7 @@ _LT_EOF
>       emximp -o $lib $output_objdir/$libname.def'
>        _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o 
> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>        _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
> +      _LT_TAGVAR(file_list_spec, $1)='@'
>        ;;
>  
>      interix[[3-9]]*)
> @@ -5874,6 +5875,7 @@ _LT_EOF
>       emximp -o $lib $output_objdir/$libname.def'
>        _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o 
> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>        _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
> +      _LT_TAGVAR(file_list_spec, $1)='@'
>        ;;
>  
>      osf3*)
> @@ -6743,6 +6745,7 @@ if test yes != "$_lt_caught_CXX_error"; then
>         emximp -o $lib $output_objdir/$libname.def'
>       _LT_TAGVAR(old_archive_From_new_cmds, $1)='emximp -o 
> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>       _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
> +     _LT_TAGVAR(file_list_spec, $1)='@'
>       ;;
>  
>        dgux*)
>