Re: [Lightning] [patch] test for zlib in configure.ac

[Paulo César Pereira de Andrade]

2013/8/27 Brandon Invergo <address@hidden>:
> Hi,

  Hi,

> In packaging lightning 2.0.0 for GNU SRC, I encountered the following
> build error:
>
> make[4]: Leaving directory 
> `/home/brandon/Projects/gsrc/trunk/gnu/lightning/work/lightning-2.0.0/lib'
> /bin/sh ../libtool  --tag=CC   --mode=link gcc -I../include -D_GNU_SOURCE -g 
> -O2  -L/home/brandon/gnu/lib -o incr incr.o ../lib/liblightning.la -lm -ldl 
> -lm -lopcodes -lbfd -liberty
> libtool: link: gcc -I../include -D_GNU_SOURCE -g -O2 -o .libs/incr incr.o  
> -L/home/brandon/gnu/lib ../lib/.libs/liblightning.so -ldl -lm -lopcodes -lbfd 
> -liberty -Wl,-rpath -Wl,/home/brandon/gnu/lib
> ../lib/.libs/liblightning.so: undefined reference to `compress'
> ../lib/.libs/liblightning.so: undefined reference to `inflate'
> ../lib/.libs/liblightning.so: undefined reference to `compressBound'
> ../lib/.libs/liblightning.so: undefined reference to `inflateEnd'
> ../lib/.libs/liblightning.so: undefined reference to `inflateInit_'
> ../lib/.libs/liblightning.so: undefined reference to `inflateReset'
> collect2: error: ld returned 1 exit status
>
> It was resolved by explicitly checking for zlib in configure.ac, which
> properly adds it to LIBS.  I've attached a patch below.

  Thanks. I committed it locally and should go in my next git push. It
was being "automatically" pulled in my build/test environments:

---%<---
$ cat /usr/lib64/libbfd.so
/* GNU ld script */

/* Ensure this .so library will not be used by a link for a different format
   on a multi-architecture system.  */
OUTPUT_FORMAT(elf64-x86-64)

/* The libz dependency is unexpected by legacy build scripts.  */
/* The libdl dependency is for plugin support.  (BZ 889134)  */
INPUT ( /usr/lib64/libbfd.a -liberty -lz -ldl )
---%<---

> Cheers,
> Brandon
>
>
>
>
>
> --
> Brandon Invergo
> http://brandon.invergo.net

Paulo