Re: [Lightning] Many tests failed on x86_32 systems

[Paulo César Pereira de Andrade]

2017-09-15 12:22 GMT-04:00 Antonio Trande <address@hidden>:
[...]
>>> This new release is successfully built but many tests fail on 32 bit
>>> systems only. I attached 'test-suite.log' file produced by 'make check'
>>> on Fedora 28 i386.
>>
>>   I just tested it. Since type punning is only done throw unions, it should
>> not be required... but please add -fno-strict-aliasing to $CFLAGS and it
>> will work.>
>>   It fails with default rpm %optflags due to generating invalid code, when
>> not properly updating the pointer where lightning writes instructions to,
>> and generating invalid opcodes.
> I will disable testing.
> On koji, they tend to fail.

  Please keep the tests during build. I will help with any failure.
  If it were not for the tests, it would not be noticed the need for
-fno-strict-aliasing in CFLAGS.

> --
> Antonio Trande
> sagitter AT fedoraproject dot org
> See my vCard.

Thanks,
Paulo