[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 2854 in lilypond: Patch: parser.yy: remove STR
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 2854 in lilypond: Patch: parser.yy: remove STRING_IDENTIFIER token |
Date: |
Wed, 26 Sep 2012 09:01:10 +0000 |
Updates:
Status: Fixed
Labels: -Patch-push Fixed_2_17_4
Comment #4 on issue 2854 by address@hidden: Patch: parser.yy: remove
STRING_IDENTIFIER token
http://code.google.com/p/lilypond/issues/detail?id=2854
Pushed to staging as
commit aaa81de1e2e7e5c69b9ad3639f12227fb83c3828
Author: David Kastrup <address@hidden>
Date: Sat Sep 22 15:35:42 2012 +0200
Issue 2854: parser.yy: remove STRING_IDENTIFIER token
A STRING_IDENTIFIER always was a special case of a MARKUP_IDENTIFIER
without being treated equally at top level. That led to craziness
like
xxx=\markup "test"
\xxx
being invalid, while
xxx=\markup \italic "test"
\xxx
was valid code. This change just removes the STRING_IDENTIFIER
category altogether. Where it was used previously, MARKUP_IDENTIFIER
is accepted now syntactically, and where the semantics indeed require
a plain string, an error is generated explicitly in the action instead
of leaving it to the parser to complain about bad grammar.