lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4955 tie-conf


From: Auto mailings of changes to Lily Issues
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4955 tie-configuration is partially ignored
Date: Sat, 20 Aug 2016 05:37:01 +0000

What about the following ad-hoc code to test for exact integers?

--- a/lily/tie-formatting-problem.cc
+++ b/lily/tie-formatting-problem.cc
@@ -1204,8 +1204,14 @@ Tie_formatting_problem::set_manual_tie_configuration (SCM manual_configs)
             {
               spec.has_manual_position_ = true;
               spec.manual_position_ = scm_to_double (scm_car (entry));
-              /* TODO: check whether inexact? is an appropriate condition here */
-              spec.has_manual_delta_y_ = (scm_is_true (scm_inexact_p (scm_car (entry))));
+              spec.has_manual_delta_y_ =
+                // values -10000 and 10000 are arbitrary
+                spec.manual_position_ < 10000
+                && spec.manual_position_ > -10000
+                // scm_is_signed_integer is true for exact integers only
+                && scm_is_false (scm_is_signed_integer (scm_car (entry),
+                                                        -10000,
+                                                        10000));
             }

           if (scm_is_number (scm_cdr (entry)))

[issues:#4955] tie-configuration is partially ignored

Status: New
Created: Fri Aug 12, 2016 07:29 AM UTC by Werner LEMBERG
Last Updated: Fri Aug 19, 2016 01:21 PM UTC
Owner: nobody
Attachments:

\version "2.19.46"

\header { texidoc = "
LilyPond should obey the vertical positions of ties as specified with
@code{tie-configuration}.

Here is a counterexample, where the positions of longer ties get
changed.
" }

\paper { line-width = 80\mm }

\relative {
  \override TieColumn.tie-configuration =
    #'((0 . 1) (2 . 1) (4 . 1))
  <b'^~ d^~ f^~>1 | \break
  q |
}

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

reply via email to

[Prev in Thread] Current Thread [Next in Thread]