[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5258 Vertical

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5258 Vertical breve rest position in TabStaff/RhythmicStaff

Date:

Thu, 18 Jan 2018 21:28:42 -0000

Issue 5258: let long rests hang from staff lines

This shifts the stencil by (staffspace - fontsize) so that the rests stay in the same space but are hang from the upper line instead of standing on the lower.

For one line staves, rests are moved one space down so that they hang.

Contains regtest.

http://codereview.appspot.com/332640043

[issues:#5258] Vertical breve rest position in TabStaff/RhythmicStaff

Status: Started
Created: Sat Jan 13, 2018 04:47 PM UTC by Malte Meyn
Last Updated: Thu Jan 18, 2018 09:28 PM UTC
Owner: Malte Meyn
Attachments:

breve_rests.png (26.0 kB; image/png)
gould_breve_rests_oneline.png (27.9 kB; image/png)

According to Gould breve rests should hang from a one line staff (RhythmicStaff) as semibreve rests do. Also, there is a comment in multi-measure-rest.cc saying

// Staff position is somewhat icky regarding its definition for
// compatibility reasons.  It is intended to be the baseline of
// a breve rest.  However, when the staff space is more than
// single space (like with tablature), it looks better if all
// rests are actually hanging.  So staff position, in reality,
// is the semi-breve position - 2.  Everything else is
// calculated from there.

This confirms what Gould writes. But the code applies only to MMRs with a measure-count > 1.

That leads to inconsistent behaviour: MultiMeasureRest breve glyphs hang, but not for single measures. Rest breve glyphs don’t hang. Instead, all breve rests should hang.

\version "2.19.80"

music = {
  \compressFullBarRests
  r1 R1 R\breve
  \time 4/2
  r\breve R\breve R\longa
  \time 8/2
  r\longa R\longa
}

\new TabStaff \with { \tabFullNotation } \music

\new RhythmicStaff \music

\new Staff \music

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot