Re: [PATCH] Tablatures and beams

[Han-Wen Nienhuys]

address@hidden writes:
> Ok, I've made a new Y-offset-callback that seems to correctly place
> fret numbers on string. I've tried several font sizes and it seems to
> work perfect.

Good; but I'm not satisfied yet. Your function is partially
duplicating Staff_symbol_referencer::callback(), and duplication is
bad. Also, the 0.65 seems rather arbitrary to me; can you explain
where this number is coming from?

If we're leaving the arbitrary offset there, we could just as well
do

   (Y-offset-callback . (,(lambda (g a) -0.65)
                         ,Staff_symbol_referencer::callback ))

> Perhaps we should have a pair of functions to ease choosing between
> printing on/above strings? Maybe \printFretNr{On|Above}Strings?

I thought that On Strings was the standard? Why do we want the switch?


-- 

 Han-Wen Nienhuys   |   address@hidden   |   http://www.xs4all.nl/~hanwen