Re: Some code for polygons

[Jan Nieuwenhuizen]

David Feuer writes:

> I didn't even think about that.  I just wrote the functions
> and gave them the interface that made the most sense to me at the
> time.  I'll change it in the next version.

Ok.

>> Btw, what about the the filled? parameter, is it never used?
>
> As far as I can tell from grepping the source, polygons are only drawn
> filled.

Ok, I'll add an assert in the c++ code and remove the parameter to match
your next polygon scheme code.

> I would suggest that the current code be put on a shelf somewhere in
> case someone needs it in the future,

Just remove it; shelve is what cvs's Attic is for ;-)

>> instead of let* ?
>
> Just a matter of style.  Internal defines are equivalent to letrec (it
> looks like they'll be equivalent to letrec* in R6RS), which is
> technically unnecessary, but I thought the code was more readable that
> way.  If you'd prefer let*, I can change to that.

Yes, please do.  Nicholas?

>> Could you send a next version as a unified diff please?
>
> Sure.

Thanks.

Please keep discussions on the list (cc'd), thanks.
Jan.

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org