lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spacing patch


From: Joe Neeman
Subject: Re: Spacing patch
Date: Thu, 4 May 2006 12:13:13 +1000
User-agent: KMail/1.8.3

On Mon, 1 May 2006 11:04, Joe Neeman wrote:
> On Mon, 1 May 2006 10:04, Han-Wen Nienhuys wrote:
> > If you have checked that the regtest document
> > looks ok, please apply the spacing patch too.
>
> I have a couple regressions that may be caused by my spacing patch (or
> maybe by some of my other changes). But I'll hold off on commiting until I
> have figured out where they come from.
>
I fixed all the regressions that I found. I attach just the diff of 
simple-spacer.cc because there were only extremely minor changes in any of 
the other files since my last patch. If you want to see the full patch again, 
though, I can send it. ChangeLog is the same as before.

Col_desc is now Column_desc -- I assume this is OK since you didn't complain 
about Rod_desc. Both names are local to the bottom half simple-spacer.cc and 
"description" is such a long word... ;)

2006-05-04  Joe Neeman <address@hidden>

        * lily/simple-spacer.cc: Remove class Simple_spacer_wrapper.
        Replace it with functions get_line_forces and get_line_configuration.
        (class Simple_spacer): Make data private.
        Rewrite compression algorithm to be faster and simpler.

        * lily/simple-spacer-scheme.cc (ly_solve_rod_and_spring_problem):
        * lily/gourlay-breaking.cc (solve):
        * lily/constrained_breaking.cc (space_line):
        Change it to the new simple-spacer code.

        * lily/paper-score.cc (get_paper_systems):
        (Paper_score):
        (process):
        Delay breaking the systems until they are requested.
        (find_break_indices):
        Use vsize for indices.
        (calc_breaking):
        Move the "Calculating line breaks" message here.

        * lily/system.cc (pre_processing):
        Move the "Calculating line breaks" message away from here.
        (break_into_pieces):
        Allow multiple calls to this function in sequence (with touching-but-
        not-overlapping breakpoints).

        * lily/constrained-breaking.cc:
        Replace most of the get_XXXX functions with get_line_details.
        Only calculate the force for each line. Calculate configurations only
        for the lines we will actually use.
        Replace cols_ with lines_.

Attachment: spacing_abbrev_20060504.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]