lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: Boxed text with rounded corners


From: Carl D. Sorensen
Subject: RE: Boxed text with rounded corners
Date: Mon, 21 Apr 2008 07:34:39 -0600

> -----Original Message-----
> From: Graham Percival [mailto:address@hidden
> Sent: Monday, April 21, 2008 5:11 AM
> To: Valentin Villenave
> Cc: lily-devel
> Subject: Re: Boxed text with rounded corners
>
> On Mon, 21 Apr 2008 10:02:45 +0200
> "Valentin Villenave" <address@hidden> wrote:
>
> > 2008/4/21 Graham Percival <address@hidden>:
> >
> > >  -- actually, it might therefore be better to add the "category"
> > >  field to define-markup-command (or build-markup or whatever it's
> > >  called) *without* using an optional argument.  That would force
> > > programmers to give them a category (even if the category
> is  simply
> > > "other"), which is exactly what we want.
> >
> > I'd prefer to (but it's just because I can't handle the
> code otherwise
> > ;)
> >
> > However, don't we risk a major breakage if doing so?
>
> How should I know?  I assume that you're going to compile
> lilypond to check it; presumably that's what you did for your
> previous patch.

I think the breakage about which Valentin is concerned is not in the LilyPond
distribution, but in user's files.  Users may have their own defined markups 
that aren't part of the distribution.  And if the category requirement is not 
optional, existing code would break (with no possibility of fixing in 
convert-ly)>

It seems to me that the category could become an optional argument to both 
define-builtin-markup-command and define-builtin-markup-list-command.  The 
default value of the optional argument would then be 'other'  or whatever is 
chosen as the 'no-other-category-is-appropriate' category name.

Carl Sorensen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]