Re: [PATCH] Re: not-so-ancient flags

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Werner,

Am Freitag, 25. Juli 2008 schrieb Werner LEMBERG:
> > Attached is a patch to implement straight flags (in modern style,
> > i.e. slanted only ~20 degrees). I think the angles (different angles
> > for up/down stems!)  and the lengths are okay, although they might
> > still be fine-tuned a bit more.
>
> Below is my patch of feta-banier.mf.

Thanks, I've some comments, though.

> The reason is simple: Note stems are drawn with rounded edges; normal
> up-flags are designed to attach directly below the rounded edge.
> Obviously, this doesn't work for straight up-flags.  My solution
> (which is tested only for optical appearance but not within a lilypond
> build) is to set the height of the straight flag to zero and retain
> the small `stem' of the flag, 

Thanks, I'll try that out!

> PS: For rapid lilypond font development, simply copy the `mf'
>     directory to a separate place.  Then for example, to test feta20,
>     say
[...]

Cool, thanks. That makes creating whole glyphs a lot easier (although it does 
not really help with glyphs that will be used to build up larger things in 
lilypond, like the grace slash, where proportions relative to other glyphs is 
relevant)

> +def create_straight_grace_dash =
> +begingroup
[...]
> +endgroup
> +enddef;
> +
> +
> +fet_beginchar ("straight grace dash (up)", "straightugrace");
> +       create_straight_grace_dash;
> +       penlabels (1, 2);
> +fet_endchar;
> +
> +
> +fet_beginchar ("straight grace dash (down)", "straightdgrace");
> +       create_straight_grace_dash;
> +       y_mirror_char;
> +fet_endchar;

I thought about that, too, but since the up/down flags use a different length 
and a different angle, I didn't extract the code to a separate definition. I 
suppose I can do it properly by passing the angle and the flag length to the 
create_straight_grace_dash definition.


The other thing that's bothering me with my patch (not your changes) is that 
in the function create_straight_flag_char I need both straight_upflag_length 
and straight_upflag_length#. I haven't found a way to pass just one of them 
and still be able to use the hashed/unhashed variable in that function. So, 
currently I pass both (as len and lenhash parameter) to it, which seems kind 
of redundant. Do you know any solution to this or do I really have pass both 
the hashed and the unhashed variable to that function?

Cheers,
Reinhold


- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIieGbTqjEwhXvPN0RAg8gAJoCM35bqpXlspuTL0gr0wXFRmvRVQCfSAYm
K4SxW0EedvWErlVI+ZYaNK8=
=BUjP
-----END PGP SIGNATURE-----