[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Use 'long long' integers in Rational class.
|
From: |
Han-Wen Nienhuys |
|
Subject: |
Re: Use 'long long' integers in Rational class. |
|
Date: |
Thu, 18 Sep 2008 12:37:13 -0300 |
Neil, could you also fix the warnings that this change generated? You
should use scm_from_int64, scm_to_int64 for conversions, otherwise
we'll get truncations in various corner cases.
On Fri, Sep 12, 2008 at 3:42 AM, <address@hidden> wrote:
> LGTM
>
> please apply.
>
>
>
> http://codereview.appspot.com/5058/diff/11/12
> File flower/include/flower-proto.hh (right):
>
> http://codereview.appspot.com/5058/diff/11/12#newcode2
> Line 2: fflower-proto.hh -- typenames in flowerlib
> ff?
>
> http://codereview.appspot.com/5058
>
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
Use 'long long' integers in Rational class., Adam Wilson, 2008/09/26