[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
* Allow for nested contexts of any depth.
From: |
hanwenn |
Subject: |
* Allow for nested contexts of any depth. |
Date: |
Tue, 07 Oct 2008 20:40:33 -0700 |
Reviewers: Neil Puttock,
http://codereview.appspot.com/7261/diff/1/2
File lily/context-def.cc (right):
http://codereview.appspot.com/7261/diff/1/2#newcode215
Line 215: seen = new set<const Context_def *> ();
Can you make a wrapper function that does
set<..> seen;
path_to (.. , &seen)
instead?
document the seen argument in the comment.
http://codereview.appspot.com/7261/diff/1/4
File ly/engraver-init.ly (left):
http://codereview.appspot.com/7261/diff/1/4#oldcode109
Line 109: \name "InnerChoirStaff"
make convert rule for this too.
Description:
* Allow for nested contexts of any depth.
- use a set to keep track of visited contexts
- remove InnerChoirStaff and InnerStaffGroup
Please review this at http://codereview.appspot.com/7261
Affected files:
M lily/context-def.cc
M lily/include/context-def.hh
M ly/engraver-init.ly
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- * Allow for nested contexts of any depth.,
hanwenn <=