Re: more code-cleanup patches

[Neil Puttock]

2009/7/21 Mark Polesky <address@hidden>:
> Here are four more code-cleanup patches.
>
> Okay to apply?

LGTM apart from a few tiny details which have caught my eye:

(0001-define-grobs.scm-Sort-interfaces.patch)

@@ -1871,10 +1870,10 @@
        (X-offset . ,ly:self-alignment-interface::x-aligned-on-self)
        (Y-offset . ,ly:staff-symbol-referencer::callback)
        (meta . ((class . Item)
-                (interfaces  . (rhythmic-head-interface
-                                font-interface
-                                rhythmic-grob-interface
+                (interfaces  . (font-interface
                                 note-head-interface
+                                rhythmic-grob-interface
+                               rhythmic-head-interface

Indentation.

@@ -2142,8 +2142,8 @@
        (Y-extent . ,ly:axis-group-interface::height)
        (Y-offset . ,ly:side-position-interface::y-aligned-side)
        (meta . ((class . Spanner)
-                (interfaces . (piano-pedal-interface
-                               axis-group-interface
+                (interfaces . (axis-group-interface
+                               piano-pedal-interface                           

Trailing spaces.

@@ -1573,8 +1572,8 @@
        (Y-extent . ,ly:axis-group-interface::height)
        (Y-offset . ,ly:side-position-interface::y-aligned-side)
        (meta . ((class . Spanner)
-                (interfaces . (piano-pedal-interface
-                               axis-group-interface
+                (interfaces . (axis-group-interface
+                               piano-pedal-interface           

Trailing spaces.

(0003-define-music-properties.scm-Sort-all-music-propertie.patch)

+     (associated-context ,string? "Name of the Voice context associated with
+this @code{\\newaddlyrics} section.")

Change \\newaddlyrics to \\lyricsto.

(0004-define-music-types.scm-Sort-music-descriptions-alist.patch)

@@ -120,6 +120,13 @@ Syntax: @address@hidden")
        (types . (general-music event breathing-event))
        ))

+    (ClusterNoteEvent
+     . ((description . "A note that is part of a cluster.")
+       ;; not a note-event, to ensure that Note_engraver doesn't eat it.

Note_heads_engraver.

Regards,
Neil