Re: Fixing configure with Autoconf 2.64

[Joe Neeman]

On Mon, 2009-08-10 at 14:23 -0700, Patrick McCarty wrote:
> On Mon, Aug 10, 2009 at 8:11 AM, Joe Neeman<address@hidden> wrote:
> > On Thu, 2009-08-06 at 10:53 -0700, Patrick McCarty wrote:
> >> On Thu, Aug 06, 2009 at 06:22:05PM +0200, John Mandereau wrote:
> >> > Le mercredi 05 août 2009 à 21:03 -0700, Patrick McCarty a écrit :
> >> > > I need this patch to run ./autogen.sh with the latest Autoconf version
> >> > > (2.64).  The only earlier version I am able to test is 2.63, which
> >> > > works fine with the patch.
> >> > >
> >> > > The warnings I am seeing and workarounds are here:
> >> > >
> >> > > http://www.gnu.org/software/hello/manual/autoconf/Expanded-Before-Required.html
> >> > >
> >> > > Okay to apply? (or is there a better fix?)
> >> >
> >> > Shouldn't AC_PROG_CC be AC_PROG_CXX? :-)
> >>
> >> That's actually a good point.  But since we've always used AC_PROG_CC,
> >> and there haven't been any reports of this not working, I think we
> >> should just keep using the same macro.
> >>
> >> > Other than this it works for me.  I'm not an expert with autoconf, so I'
> >> > don't know about possible better fixes.
> >>
> >> After looking into this some more, I think this fix is perfectly safe
> >> for any Autoconf version.  Autoconf 2.64 catches cases of incorrect
> >> macro nesting, so expanding AC_PROG_CC before stepmake is initialized
> >> should be all that's needed.
> >>
> >> I'll push.
> >
> > This seems to have broken the --disable-optimising argument to
> > configure. With commit 74bdeea4, I get
> > $ ./autogen.sh --disable-optimising
> > $ grep O2 config.make
> > (nothing)
> >
> > With this patch (40911543), I get
> > $ ./autogen.sh --disable-optimising
> > $ grep O2 config.make
> > CONFIG_CFLAGS = -g -O2  -g -pipe $(GUILE_CFLAGS) $(FREETYPE2_CFLAGS)
> > $(PANGO_FT2_CFLAGS)
> > CONFIG_CXXFLAGS = -g -O2  -g -pipe $(GUILE_CFLAGS) $(FREETYPE2_CFLAGS)
> > $(PANGO_FT2_CFLAGS)
> >
> > My autoconf is version 2.63
> 
> Sorry about that, Joe.  I could reproduce with Autoconf 2.64 as well.
> 
> Can you test the latest git to see if it works now?

All better now, thanks.
Joe