|
From: | Michael Käppler |
Subject: | Re: Implement new handling for \paper margin settings. |
Date: | Thu, 20 Aug 2009 17:36:05 +0200 |
User-agent: | Thunderbird 2.0.0.12 (X11/20071114) |
Hi Carl,
that's a good point. However, I'm going to be on vacation for a week and will rewrite this when I come back.LGTM. I do have one comment about tests for != SCM_UNDEFINED. It think there's less chance of confusion when testing for "undefined" rather than "not undefined", which is "defined". The double negative (not undefined) can potentially be confusing.
Regards, Michael
[Prev in Thread] | Current Thread | [Next in Thread] |