[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] to let \epsfile always start the eps file at (0, 0) in the stenc
From: |
Reinhold Kainhofer |
Subject: |
[PATCH] to let \epsfile always start the eps file at (0, 0) in the stencil |
Date: |
Wed, 26 Aug 2009 00:43:43 +0200 |
User-agent: |
KMail/1.11.4 (Linux/2.6.29-02062906-generic; KDE/4.2.4; i686; ; ) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
This patch lets an included EPS file always start at the origin of the stencil:
http://codereview.appspot.com/109079
Okay to apply?
The problem so far was that lilypond used the (scaled) exact coordinates of
the bounding box as the coordinates of the object in the stencil. Now, since
hardly any EPS will have its visual lower left corner at coordinates (0,0),
this will leave all EPS file displaced quite a lot. For example, The following
code includes the CC-licence EPS and our usual context-example.eps example:
\markup\concat{ ABC \rounded-box \epsfile #Y #3 #"cc-by.eps" DEF}
\markup\concat{ ABC \rounded-box \epsfile #Y #20 #"context-example.eps" DEF}
\markup\concat{ ABC \rounded-box \epsfile #X #20 #"context-example.eps" DEF}
\markup\concat{ ABC \rounded-box \epsfile #Y #3 #"cc-by.eps" DEF}
I would expect this to be ABC[Box with EPS]DEF in all cases, right?
The output (before the patch) can be seen at:
http://www.fam.tuwien.ac.at/~reinhold/LilyPond/eps-file.old.pdf
This is clearly not what one would expect.
The result with that patch is more what one would expect:
http://www.fam.tuwien.ac.at/~reinhold/LilyPond/eps-file.new.pdf
The image in the documentation of \epsfile
(http://kainhofer.com/~lilypond/Documentation/notation/Graphic.html#Graphic)
will of course also look a bit different (the two eps files won't overlap any
more, which is also what I would expect, anyway):
http://www.fam.tuwien.ac.at/~reinhold/LilyPond/lily-6692447e.pdf
Okay to apply?
Cheers,
Reinhold
- --
- ------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
* Financial & Actuarial Math., Vienna Univ. of Technology, Austria
* http://www.fam.tuwien.ac.at/, DVR: 0005886
* LilyPond, Music typesetting, http://www.lilypond.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFKlGkfTqjEwhXvPN0RAlItAJ9MeIZd1S9dn4h0C4r/byi3CfYLFgCZAUfa
KWA9z8jaF/OfFfYoLsUvv7k=
=AIbd
-----END PGP SIGNATURE-----
- [PATCH] to let \epsfile always start the eps file at (0, 0) in the stencil,
Reinhold Kainhofer <=