[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Add option to indicate frets by letters in tablature (issue164063)
From: |
n . puttock |
Subject: |
Add option to indicate frets by letters in tablature (issue164063) |
Date: |
Wed, 02 Dec 2009 22:19:33 +0000 |
Hi Trevor,
This looks OK apart from a few minor details (I've mentioned the
interface/doc issues in the main thread).
I look forward to the next instalment.
Cheers,
Neil
http://codereview.appspot.com/164063/diff/1/2
File input/regression/tablature-letter.ly (right):
http://codereview.appspot.com/164063/diff/1/2#newcode3
input/regression/tablature-letter.ly:3: \header{ texidoc = "@cindex
Tabulature-letter
\header {
tablature-letter
http://codereview.appspot.com/164063/diff/1/2#newcode13
input/regression/tablature-letter.ly:13: }
no indent
http://codereview.appspot.com/164063/diff/1/2#newcode15
input/regression/tablature-letter.ly:15: partition = {
= {
http://codereview.appspot.com/164063/diff/1/3
File lily/tab-note-heads-engraver.cc (right):
http://codereview.appspot.com/164063/diff/1/3#newcode140
lily/tab-note-heads-engraver.cc:140: if (to_boolean (note->get_property
("whiteout")))
Is this useful enough to make available to all grobs?
It could be added to grob.cc (where 'transparent and 'rotation are
processed), though the code would be a bit more convoluted. :)
http://codereview.appspot.com/164063/diff/1/6
File scm/translation-functions.scm (left):
http://codereview.appspot.com/164063/diff/1/6#oldcode395
scm/translation-functions.scm:395: (make-vcenter-markup
reindent
http://codereview.appspot.com/164063/diff/1/6#oldcode415
scm/translation-functions.scm:415: (make-vcenter-markup
reindent
http://codereview.appspot.com/164063/diff/1/6
File scm/translation-functions.scm (right):
http://codereview.appspot.com/164063/diff/1/6#newcode396
scm/translation-functions.scm:396: (letters (ly:context-property context
'fretLetters))
Could this context prop be a bit more descriptive?
Perhaps something like
fretLetterExceptions
http://codereview.appspot.com/164063/diff/1/6#newcode400
scm/translation-functions.scm:400: (if (< fret (length letters))
indent
(+ following lines)
http://codereview.appspot.com/164063
- Add option to indicate frets by letters in tablature (issue164063),
n . puttock <=