[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH: Refactor script-column.cc for improved reading and fewer line
From: |
Han-Wen Nienhuys |
Subject: |
Re: PATCH: Refactor script-column.cc for improved reading and fewer lines |
Date: |
Fri, 4 Dec 2009 17:02:10 -0200 |
While having these explanations in mail is nice, it would be best to
put as much of possible of these comments into the code.
On Fri, Dec 4, 2009 at 4:53 PM, Carl Sorensen <address@hidden> wrote:
>>> Please review the code at
>>>
>>> http://codereview.appspot.com/166057
>>
>> I have a very hard time picking the code apart. default_outside_staff
>> and last_outside_staff are used somewhat interchangeably, likely one of
>> the two should go.
>
> No. Default_outside_staff is the incoming (default) outside_staff_priority
> of the previous grob. Last_outside_staff is the outside_staff priority of
[..]
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
- PATCH: Refactor script-column.cc for improved reading and fewer lines, Carl Sorensen, 2009/12/04
- Re: PATCH: Refactor script-column.cc for improved reading and fewer lines, Trevor Daniels, 2009/12/05
- Re: PATCH: Refactor script-column.cc for improved reading and fewer lines, David Kastrup, 2009/12/05
- Re: PATCH: Refactor script-column.cc for improved reading and fewer lines, Carl Sorensen, 2009/12/05
- Re: PATCH: Refactor script-column.cc for improved reading and fewer lines, Carl Sorensen, 2009/12/05
- Re: PATCH: Refactor script-column.cc for improved reading and fewer lines, Trevor Daniels, 2009/12/05
- Re: PATCH: Refactor script-column.cc for improved reading and fewer lines, Carl Sorensen, 2009/12/05