Re: [PATCH] Quoting different types of events for \cueDuring and \quoteDuring

[Reinhold Kainhofer]

Am Dienstag, 22. Dezember 2009 18:27:43 schrieb Ian Hulin:
> Hi Reinhold,
> 
> On 22/12/09 15:34, Reinhold Kainhofer wrote:
> > Typically, \quoteDuring is used to duplicate everything in a voice,
> > while \cueDuring is used to only quote the notes, but not e.g.
> > phrasing, slurs, accents, markup, etc.
> >
> > So, this patch adds an additional property quotedCueEventTypes in
> > addition to quotedEventTypes, which allows to quote different types
> > for \cueDuring than for \quoteDuring.
> >
> > By default, \quoteDuring now quotes everything (i.e. StreamEvent), while
> > \cueDuring quotes only notes, rest, ties, beams and tuplets.
> >
> > Here's the patch (also includes a regtest):
> > http://codereview.appspot.com/180114
> >
> > Okay to apply?
> 
> Will the docs make the distinction about \quoteDuring vs. \cueDuring
> usage clear?

Actually, the docs already say that \quoteDuring is used to duplicate another 
voice (which was NOT true, only pitch and rhythm was quoted, but no 
articulations, slurs, etc.).

> I can see there is stuff in the amended docstrings in
> define-context-properties.scm which will go into the docs somewhere but
> do you feel that's enough for end-users?

The docs on quoteDuring and cueDuring is not very good right now. In 
particular, quotedEventTypes is documented only in one snippet, that removes 
quoting rests (but does not show how to quote more than only notes, rests and 
ties).

Cheers,
Reinhold

-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org