Re: [PATCH] Use find ... | xargs rm -f instead of find ... -delete

[John Mandereau]

Le mardi 29 décembre 2009 à 22:05 +0100, Matthias Kilian a écrit :
> `must' is such a strong word. There are other GNUisms (or non-portable
> extensions) hidden in the build system, like that `grep -L' at some
> places.

This will disappear in some future (when Texinfo has a good enough i18n
support, maybe not before the next major version of Texinfo).


> If you guys hesitate to apply patches like the one I sent (and David
> is right in that my patch introduces a potential risk), that's
> perfectly ok for me. I've two branches on my disk: `mystuff'
> (containing patches I think may be helpful for all systems), and
> `openbsdhacks' (copntaining additional patches I need to get LilyPond
> built on OpenBSD, and that are probably less important for you). I
> could just move the find(1) diff to my `openbsdhacks' branch.

I think we shouldn't hesitate in any case the GNUism is replaced by
something as reliable and not significantly more complicated.


> It's probably an esoteric issue for LilyPond, but someone may copy
> and use this unsafe command for his own project or in some random
> shell script.

Errm, who would be crazy enough to learn good shell programming from
LilyPond makefiles? :-)  More seriously, I agree with Graham about the
security issues; if somebody has good reasons to be picky about building
LilyPond (or any software) in a secure way, she should build in a
visrtual machine or chroot jail.  FWIW building Lily under a dedicated
user account is enough for me.

Best,
John

signature.asc
Description: Ceci est une partie de message numériquement signée