[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Avoid orphan/widow lines (issue190102)
From: |
joeneeman |
Subject: |
Re: Avoid orphan/widow lines (issue190102) |
Date: |
Thu, 21 Jan 2010 20:45:06 +0000 |
lgtm, modulo some more formatting nitpicking. If you fix the formatting
and mail me the patch, I'll push it.
Also, in the future, please add address@hidden to the CC list (I
should have mentioned it, sorry).
http://codereview.appspot.com/190102/diff/1/2
File lily/constrained-breaking.cc (right):
http://codereview.appspot.com/190102/diff/1/2#newcode529
lily/constrained-breaking.cc:529: last_markup_line_ =
to_boolean(last_scm);
space before (
http://codereview.appspot.com/190102/diff/1/2#newcode531
lily/constrained-breaking.cc:531: first_markup_line_ =
to_boolean(first_scm);
space before (
http://codereview.appspot.com/190102/diff/1/7
File lily/paper-book.cc (right):
http://codereview.appspot.com/190102/diff/1/7#newcode554
lily/paper-book.cc:554: {
indentation should be
if (blah)
{
foo();
}
http://codereview.appspot.com/190102/diff/1/7#newcode558
lily/paper-book.cc:558: ps->set_property
("first-markup-line", SCM_BOOL_F);
extra spaces?
http://codereview.appspot.com/190102/show
- Re: Avoid orphan/widow lines (issue190102),
joeneeman <=