lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix issue 1011


From: Graham Percival
Subject: Re: [PATCH] Fix issue 1011
Date: Sat, 13 Feb 2010 18:40:48 +0000
User-agent: Mutt/1.5.18 (2008-05-17)

On Sat, Feb 13, 2010 at 11:23:25AM -0700, Carl Sorensen wrote:
> 
> On 2/13/10 10:45 AM, "Christian Hitz" <address@hidden> wrote:
> 
> > In order to verify the fix I have added a new regression test suite
> > lilypondbook_html. It tests the lilypond-book operation when processing HTML
> > files. Most of the patch is related to this regression test.
> > 
> > http://codereview.appspot.com/206092/show
> 
> Looks good to me, but I'm always nervous about patches on the makefile
> system.

I'll start testing it as soon as 2.13.13 is uploaded.

> > Note: Rietveld insists on squashing my Git commits. I'll provide a set of
> > patches when the changes are ready to be pushed.
> 
> Yes, that's how Rietveld works.  If you want to keep patches separate, you
> can do so by putting each patch on a separate branch.

That sucks.  :(


I'll probably split it a bit myself -- extract the change to
lilypond-book, test+apply that, then look at the testing suite
stuff.

Cheers,
- Graham




reply via email to

[Prev in Thread] Current Thread [Next in Thread]