lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Support multi-slash and mixed-duration beat repeats


From: Neil Puttock
Subject: [PATCH] Support multi-slash and mixed-duration beat repeats
Date: Thu, 18 Feb 2010 00:36:04 +0000

Hi everybody,

I've posted a patch on Rietveld which enhances the behaviour of
\repeat percent by allowing single-beat repeats to be shown with
multiple slashes (if all durations are equal and duration >=
semiquaver) or as double-percent glyphs (varying durations).

I've moved the handling of the different percent repeat types out of
the Percent_repeat_engraver and in to the Percent_repeat_iterator,
which now sends synthetic events for each of the repeat styles:
PercentEvent, DoublePercentEvent and RepeatSlashEvent.

One thing I'm a bit unsure about is where to calculate the
slash-count: though I've settled for calling a (for the time being
inefficient and lazily coded :) scheme proc from the iterator, I
wonder whether this is the best approach (it would of course be easy
to do this in C++ instead).

Please review here: http://codereview.appspot.com/212048

Thanks,
Neil

Attachment: beat-percents.png
Description: PNG image


reply via email to

[Prev in Thread] Current Thread [Next in Thread]